pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix places in TestLib.pm in need of adaptation to the output of
Date: Tue, 21 Sep 2021 23:45:01 +0000
Message-ID: <E1mSpRd-0007jV-BQ@gemulon.postgresql.org> (raw)

Fix places in TestLib.pm in need of adaptation to the output of Msys perl

Contrary to the output of native perl, Msys perl generates outputs with
CRLFs characters.  There are already places in the TAP code where CRLFs
(\r\n) are automatically converted to LF (\n) on Msys, but we missed a
couple of places when running commands and using their output for
comparison, that would lead to failures.

This problem has been found thanks to the test added in 5adb067 using
TestLib::command_checks_all(), but after a closer look more code paths
were missing a filter.

This is backpatched all the way down to prevent any surprises if a new
test is introduced in stable branches.

Reviewed-by: Andrew Dunstan, Álvaro Herrera
Discussion: https://postgr.es/m/1252480.1631829409@sss.pgh.pa.us
Backpatch-through: 9.6

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/583e15af9976f8905e2b27f985d619e758270e16

Modified Files
--------------
src/test/perl/TestLib.pm | 5 +++++
1 file changed, 5 insertions(+)



view thread (7+ messages)  latest in thread

Message-ID: <E1mSpRd-0007jV-BQ@gemulon.postgresql.org>
Permalink:  ../E1mSpRd-0007jV-BQ@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mSpRd-0007jV-BQ@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Fix places in TestLib.pm in need of adaptation to the output of
  In-Reply-To: <E1mSpRd-0007jV-BQ@gemulon.postgresql.org>
  References: <E1mSpRd-0007jV-BQ@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox