pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix some issues with TAP tests for postgres -C
Date: Wed, 22 Sep 2021 01:14:02 +0000
Message-ID: <E1mSqpm-0008CL-54@gemulon.postgresql.org> (raw)

Fix some issues with TAP tests for postgres -C

This addresses two issues with the tests added in 0c39c292 for runtime
GUCs:
- Re-enable the test on Msys.  The test could fail because of \r\n
generated by Msys perl.  0d91c52a has taken care of this issue.
- Allow the test to run in the context of a privileged account.  CIs
running under privileged accounts would fail on permission failures, as
reported by Andres Freund.  This issue is fixed by wrapping the postgres
command within pg_ctl as the latter will take care of any permissions
needed.  The test checking a failure of postgres -C for a runtime
parameter with an instance running is removed, as pg_ctl produces an
unstable error code (no need for a CI to reproduce that).

Discussion: https://postgr.es/m/20210921032040.lyl4lcax37aedx2x@alap3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1a9d802828110c87a207785aaf6b00d8917a86ad

Modified Files
--------------
src/bin/pg_checksums/t/002_actions.pl | 37 +++++++++++++----------------------
1 file changed, 14 insertions(+), 23 deletions(-)



Message-ID: <E1mSqpm-0008CL-54@gemulon.postgresql.org>
Permalink:  ../E1mSqpm-0008CL-54@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mSqpm-0008CL-54@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Fix some issues with TAP tests for postgres -C
  In-Reply-To: <E1mSqpm-0008CL-54@gemulon.postgresql.org>
  References: <E1mSqpm-0008CL-54@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox