pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Fujii Masao <fujii@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: postgres_fdw: Refactor transaction rollback code to avoid code d
Date: Wed, 22 Sep 2021 14:48:54 +0000
Message-ID: <E1mT3YM-0004YB-AE@gemulon.postgresql.org> (raw)

postgres_fdw: Refactor transaction rollback code to avoid code duplication.

In postgres_fdw, pgfdw_xact_callback() and pgfdw_subxact_callback()
callback functions do almost the same thing to rollback remote toplevel-
and sub-transaction. But previously their such rollback logics were
implemented separately in each function and in different way. Which
could decrease the readability and maintainability of the code.

To fix the issue, this commit creates the common function to rollback
remote transactions, and makes those callback functions use it. Which
allows us to avoid unnecessary code duplication.

Author: Fujii Masao
Reviewed-by: Zhihong Yu, Bharath Rupireddy
Discussion: https://postgr.es/m/62fbb63a-d46c-fb47-a56d-f6be1909aa44@oss.nttdata.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/85c69611288f4096b7460d980bedaa777f824d24

Modified Files
--------------
contrib/postgres_fdw/connection.c | 177 ++++++++++++++++----------------------
1 file changed, 75 insertions(+), 102 deletions(-)



Message-ID: <E1mT3YM-0004YB-AE@gemulon.postgresql.org>
Permalink:  ../E1mT3YM-0004YB-AE@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mT3YM-0004YB-AE@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: fujii@postgresql.org
  Subject: Re: pgsql: postgres_fdw: Refactor transaction rollback code to avoid code d
  In-Reply-To: <E1mT3YM-0004YB-AE@gemulon.postgresql.org>
  References: <E1mT3YM-0004YB-AE@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox