From: Peter Geoghegan <pg@bowt.ie>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Document issue with heapam line pointer truncation.
Date: Thu, 23 Sep 2021 02:21:49 +0000
Message-ID: <E1mTEMv-00007x-Bs@gemulon.postgresql.org> (raw)
Document issue with heapam line pointer truncation.
Checking that an offset number isn't past the end of a heap page's line
pointer array was just a defensive sanity check for HOT-chain traversal
code before commit 3c3b8a4b. It's etrictly necessary now, though. Add
comments that reference the issue to code in heapam that needs to get it
right.
Per suggestion from Alexander Lakhin.
Discussion: https://postgr.es/m/f76a292c-9170-1aef-91a0-59d9443b99a3@gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/c7aeb775df895db240dcd6f47242f7e08899adfb
Modified Files
--------------
src/backend/access/heap/heapam.c | 11 +++++++++--
src/backend/access/heap/pruneheap.c | 22 ++++++++++++++++++----
2 files changed, 27 insertions(+), 6 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: pg@bowt.ie
Subject: Re: pgsql: Document issue with heapam line pointer truncation.
In-Reply-To: <E1mTEMv-00007x-Bs@gemulon.postgresql.org>
References: <E1mTEMv-00007x-Bs@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox