pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Release memory allocated by dependency_degree
Date: Thu, 23 Sep 2021 16:40:23 +0000
Message-ID: <E1mTRln-0005AJ-IZ@gemulon.postgresql.org> (raw)

Release memory allocated by dependency_degree

Calculating degree of a functional dependency may allocate a lot of
memory - we have released mot of the explicitly allocated memory, but
e.g. detoasted varlena values were left behind. That may be an issue,
because we consider a lot of dependencies (all combinations), and the
detoasting may happen for each one again.

Fixed by calling dependency_degree() in a dedicated context, and
resetting it after each call. We only need the calculated dependency
degree, so we don't need to copy anything.

Backpatch to PostgreSQL 10, where extended statistics were introduced.

Backpatch-through: 10
Discussion: https://www.postgresql.org/message-id/20210915200928.GP831%40telsasoft.com

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c0386f403a832f50d61fc7bb9bb265f7700273f3

Modified Files
--------------
src/backend/statistics/dependencies.c | 23 ++++++++++++++++-------
1 file changed, 16 insertions(+), 7 deletions(-)



view thread (6+ messages)  latest in thread

Message-ID: <E1mTRln-0005AJ-IZ@gemulon.postgresql.org>
Permalink:  ../E1mTRln-0005AJ-IZ@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mTRln-0005AJ-IZ@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tomas.vondra@postgresql.org
  Subject: Re: pgsql: Release memory allocated by dependency_degree
  In-Reply-To: <E1mTRln-0005AJ-IZ@gemulon.postgresql.org>
  References: <E1mTRln-0005AJ-IZ@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox