pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Clarify use of "statistics objects" in the code
Date: Wed, 29 Sep 2021 06:30:30 +0000
Message-ID: <E1mVT6s-0003s0-OF@gemulon.postgresql.org> (raw)

Clarify use of "statistics objects" in the code

The code inconsistently used "statistic object" or "statistics" where
the correct term, as discussed, is actually "statistics object".  This
improves the state of the code to be more consistent.

While on it, fix an incorrect error message introduced in a4d75c8.  This
error should never happen, as the code states, but it would be
misleading.

Author: Justin Pryzby
Reviewed-by: Álvaro Herrera, Michael Paquier
Discussion: https://postgr.es/m/20210924215827.GS831@telsasoft.com
Backpatch-through: 14

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/2cf9cf5d7b5e66202389618a4c08945da352b35c

Modified Files
--------------
src/backend/commands/statscmds.c        | 28 ++++++++++++++--------------
src/backend/commands/tablecmds.c        |  8 ++++----
src/backend/parser/parse_utilcmd.c      |  6 +++---
src/backend/statistics/extended_stats.c | 18 +++++++++---------
src/backend/utils/adt/selfuncs.c        | 28 ++++++++++++++--------------
5 files changed, 44 insertions(+), 44 deletions(-)



view thread (2+ messages)

Message-ID: <E1mVT6s-0003s0-OF@gemulon.postgresql.org>
Permalink:  ../E1mVT6s-0003s0-OF@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mVT6s-0003s0-OF@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Clarify use of "statistics objects" in the code
  In-Reply-To: <E1mVT6s-0003s0-OF@gemulon.postgresql.org>
  References: <E1mVT6s-0003s0-OF@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox