pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Fujii Masao <fujii@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pgbench: Fix handling of socket errors during benchmark.
Date: Wed, 29 Sep 2021 12:50:02 +0000
Message-ID: <E1mVZ2A-00061v-Ua@gemulon.postgresql.org> (raw)

pgbench: Fix handling of socket errors during benchmark.

Previously socket errors such as invalid socket or socket wait method failures
during benchmark caused pgbench to exit with status 0. Instead, errors during
the run should result in exit status 2.

Back-patch to v12 where pgbench started reporting exit status.

Original complaint and patch by Hayato Kuroda.

Author: Yugo Nagata, Fabien COELHO
Reviewed-by: Kyotaro Horiguchi, Fujii Masao
Discussion: https://postgr.es/m/TYCPR01MB5870057375ACA8A73099C649F5349@TYCPR01MB5870.jpnprd01.prod.outlook.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2acb7cc6b56c2b80029c202217e19553578456e9

Modified Files
--------------
src/bin/pgbench/pgbench.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



view thread (4+ messages)  latest in thread

Message-ID: <E1mVZ2A-00061v-Ua@gemulon.postgresql.org>
Permalink:  ../E1mVZ2A-00061v-Ua@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mVZ2A-00061v-Ua@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: fujii@postgresql.org
  Subject: Re: pgsql: pgbench: Fix handling of socket errors during benchmark.
  In-Reply-To: <E1mVZ2A-00061v-Ua@gemulon.postgresql.org>
  References: <E1mVZ2A-00061v-Ua@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox