pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Ensure interleaved_parts field is always initialized
Date: Fri, 01 Oct 2021 02:10:38 +0000
Message-ID: <E1mW80U-00028V-L7@gemulon.postgresql.org> (raw)

Ensure interleaved_parts field is always initialized

This field was recently added in db632fbca, however that commit missed one
place where it should have initialized the new field to NULL.  The missed
location is where the PartitionBoundInfo is created for partition-wise
join relations.  Technically there could be interleaved partitions in a
partition-wise join relation, but currently the only optimization we use
this field for only does so for base rels and other member rels.  So just
document that we don't populate this field for join rels.

Reported-by: Amit Langote
Author: Amit Langote, David Rowley
Reviewed-by: Amit Langote, David Rowley
Discussion: https://postgr.es/m/CA+HiwqE76Rps24kwHsd2Cr82Ua07tJC9t9reG0c7ScX9n_xrEA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/16239c5fdf6e457f8274c49209d1fbdeab472703

Modified Files
--------------
src/backend/partitioning/partbounds.c | 3 +++
src/include/partitioning/partbounds.h | 4 +++-
2 files changed, 6 insertions(+), 1 deletion(-)



Message-ID: <E1mW80U-00028V-L7@gemulon.postgresql.org>
Permalink:  ../E1mW80U-00028V-L7@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mW80U-00028V-L7@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: drowley@postgresql.org
  Subject: Re: pgsql: Ensure interleaved_parts field is always initialized
  In-Reply-To: <E1mW80U-00028V-L7@gemulon.postgresql.org>
  References: <E1mW80U-00028V-L7@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox