From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove unstable, unnecessary test; fix typo
Date: Fri, 01 Oct 2021 21:04:02 +0000
Message-ID: <E1mWPhK-0000LF-Gy@gemulon.postgresql.org> (raw)
Remove unstable, unnecessary test; fix typo
Commit ff9f111bce24 added some test code that's unportable and doesn't
add meaningful coverage. Remove it rather than try and get it to work
everywhere.
While at it, fix a typo in a log message added by the aforementioned
commit.
Backpatch to 14.
Discussion: https://postgr.es/m/3000074.1632947632@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d186d233dfde4afb9dff346e13c8adaf4deec6b3
Modified Files
--------------
src/backend/access/transam/xlog.c | 2 +-
src/test/recovery/t/026_overwrite_contrecord.pl | 116 +-----------------------
src/test/recovery/t/idiosyncratic_copy | 20 ----
3 files changed, 3 insertions(+), 135 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: alvherre@alvh.no-ip.org
Subject: Re: pgsql: Remove unstable, unnecessary test; fix typo
In-Reply-To: <E1mWPhK-0000LF-Gy@gemulon.postgresql.org>
References: <E1mWPhK-0000LF-Gy@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox