pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Error out if SKIP LOCKED and WITH TIES are both specified
Date: Fri, 01 Oct 2021 21:31:17 +0000
Message-ID: <E1mWQ7h-0000VJ-19@gemulon.postgresql.org> (raw)

Error out if SKIP LOCKED and WITH TIES are both specified

Both bugs #16676[1] and #17141[2] illustrate that the combination of
SKIP LOCKED and FETCH FIRST WITH TIES break expectations when it comes
to rows returned to other sessions accessing the same row.  Since this
situation is detectable from the syntax and hard to fix otherwise,
forbid for now, with the potential to fix in the future.

[1] https://postgr.es/m/16676-fd62c3c835880da6@postgresql.org
[2] https://postgr.es/m/17141-913d78b9675aac8e@postgresql.org

Backpatch-through: 13, where WITH TIES was introduced
Author: David Christensen <david.christensen@crunchydata.com>
Discussion: https://postgr.es/m/CAOxo6XLPccCKru3xPMaYDpa+AXyPeWFs+SskrrL+HKwDjJnLhg@mail.gmail.com

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/170206e458bce1d4be34bb805f884b2735430519

Modified Files
--------------
doc/src/sgml/ref/select.sgml        |  3 ++-
src/backend/commands/matview.c      |  3 ++-
src/backend/parser/gram.y           | 15 +++++++++++++++
src/test/regress/expected/limit.out |  5 +++++
src/test/regress/sql/limit.sql      |  5 +++++
5 files changed, 29 insertions(+), 2 deletions(-)



view thread (3+ messages)

Message-ID: <E1mWQ7h-0000VJ-19@gemulon.postgresql.org>
Permalink:  ../E1mWQ7h-0000VJ-19@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mWQ7h-0000VJ-19@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org
  Subject: Re: pgsql: Error out if SKIP LOCKED and WITH TIES are both specified
  In-Reply-To: <E1mWQ7h-0000VJ-19@gemulon.postgresql.org>
  References: <E1mWQ7h-0000VJ-19@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox