pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Daniel Gustafsson <dgustafsson@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Provide error hint on exit() check when building libpq
Date: Mon, 04 Oct 2021 12:33:56 +0000
Message-ID: <E1mXNAK-0004Ja-FP@gemulon.postgresql.org> (raw)

Provide error hint on exit() check when building libpq

Commit dc227eb82 introduced a restriction on libpq that no functions which
invoke exit() are allowed to be called. This was further refined and fixed
in e45b0dfa1f and 2f7bae2f92 and 792259591. While this is well documented
in the Makefile, the error message emitted when the check failed was terse,
without hints for new developers without prior context. This adds an error
hint to assist new developers onboarding to postgres.

Author: Rachel Heaton <rheaton@vmware.com>
Co-authored-by: Jacob Champion <pchampion@vmware.com>
Discussion: https://postgr.es/m/CADJcwiVL20955HCNzDqz9BEDr6A77pz6-nac5sbZVvhAEMijLg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e9bc0441f1446f6614fa6712841acec91890e089

Modified Files
--------------
src/interfaces/libpq/Makefile | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)



Message-ID: <E1mXNAK-0004Ja-FP@gemulon.postgresql.org>
Permalink:  ../E1mXNAK-0004Ja-FP@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mXNAK-0004Ja-FP@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: dgustafsson@postgresql.org
  Subject: Re: pgsql: Provide error hint on exit() check when building libpq
  In-Reply-To: <E1mXNAK-0004Ja-FP@gemulon.postgresql.org>
  References: <E1mXNAK-0004Ja-FP@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox