pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix TestLib::slurp_file() with offset on windows. 7+ messages / 1 participants [nested] [flat]
* pgsql: Fix TestLib::slurp_file() with offset on windows. @ 2021-10-04 20:49 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 7+ messages in thread From: Andres Freund @ 2021-10-04 20:49 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix TestLib::slurp_file() with offset on windows. 3c5b0685b921 used setFilePointer() to set the position of the filehandle, but passed the wrong filehandle, always leaving the position at 0. Instead of just fixing that, remove use of setFilePointer(), we have a perl fd at this point, so we can just use perl's seek(). Additionally, the perl filehandle wasn't closed, just the windows filehandle. Reviewed-By: Andrew Dunstan <andrew@dunslane.net> Author: Andres Freund <andres@anarazel.de> Discussion: https://postgr.es/m/20211003173038.64mmhgxctfqn7wl6@alap3.anarazel.de Backpatch: 9.6-, like 3c5b0685b921 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/2f74db1236fe83e6665e5b0ddad4454c69495614 Modified Files -------------- src/test/perl/TestLib.pm | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix TestLib::slurp_file() with offset on windows. @ 2021-10-04 20:49 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 7+ messages in thread From: Andres Freund @ 2021-10-04 20:49 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix TestLib::slurp_file() with offset on windows. 3c5b0685b921 used setFilePointer() to set the position of the filehandle, but passed the wrong filehandle, always leaving the position at 0. Instead of just fixing that, remove use of setFilePointer(), we have a perl fd at this point, so we can just use perl's seek(). Additionally, the perl filehandle wasn't closed, just the windows filehandle. Reviewed-By: Andrew Dunstan <andrew@dunslane.net> Author: Andres Freund <andres@anarazel.de> Discussion: https://postgr.es/m/20211003173038.64mmhgxctfqn7wl6@alap3.anarazel.de Backpatch: 9.6-, like 3c5b0685b921 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c4465cd09e3ab034ced25e623d5760e9ce437f6c Modified Files -------------- src/test/perl/TestLib.pm | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix TestLib::slurp_file() with offset on windows. @ 2021-10-04 20:49 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 7+ messages in thread From: Andres Freund @ 2021-10-04 20:49 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix TestLib::slurp_file() with offset on windows. 3c5b0685b921 used setFilePointer() to set the position of the filehandle, but passed the wrong filehandle, always leaving the position at 0. Instead of just fixing that, remove use of setFilePointer(), we have a perl fd at this point, so we can just use perl's seek(). Additionally, the perl filehandle wasn't closed, just the windows filehandle. Reviewed-By: Andrew Dunstan <andrew@dunslane.net> Author: Andres Freund <andres@anarazel.de> Discussion: https://postgr.es/m/20211003173038.64mmhgxctfqn7wl6@alap3.anarazel.de Backpatch: 9.6-, like 3c5b0685b921 Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5ba397f7404e911c7822e85441d42673080c5b98 Modified Files -------------- src/test/perl/TestLib.pm | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix TestLib::slurp_file() with offset on windows. @ 2021-10-04 20:49 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 7+ messages in thread From: Andres Freund @ 2021-10-04 20:49 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix TestLib::slurp_file() with offset on windows. 3c5b0685b921 used setFilePointer() to set the position of the filehandle, but passed the wrong filehandle, always leaving the position at 0. Instead of just fixing that, remove use of setFilePointer(), we have a perl fd at this point, so we can just use perl's seek(). Additionally, the perl filehandle wasn't closed, just the windows filehandle. Reviewed-By: Andrew Dunstan <andrew@dunslane.net> Author: Andres Freund <andres@anarazel.de> Discussion: https://postgr.es/m/20211003173038.64mmhgxctfqn7wl6@alap3.anarazel.de Backpatch: 9.6-, like 3c5b0685b921 Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/cd1b2334b8a2c18f54e7ade408c9133805cae557 Modified Files -------------- src/test/perl/TestLib.pm | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix TestLib::slurp_file() with offset on windows. @ 2021-10-04 20:49 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 7+ messages in thread From: Andres Freund @ 2021-10-04 20:49 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix TestLib::slurp_file() with offset on windows. 3c5b0685b921 used setFilePointer() to set the position of the filehandle, but passed the wrong filehandle, always leaving the position at 0. Instead of just fixing that, remove use of setFilePointer(), we have a perl fd at this point, so we can just use perl's seek(). Additionally, the perl filehandle wasn't closed, just the windows filehandle. Reviewed-By: Andrew Dunstan <andrew@dunslane.net> Author: Andres Freund <andres@anarazel.de> Discussion: https://postgr.es/m/20211003173038.64mmhgxctfqn7wl6@alap3.anarazel.de Backpatch: 9.6-, like 3c5b0685b921 Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/0a134c860fc116a3f1eed71fbdcf48b66221b456 Modified Files -------------- src/test/perl/TestLib.pm | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix TestLib::slurp_file() with offset on windows. @ 2021-10-04 20:49 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 7+ messages in thread From: Andres Freund @ 2021-10-04 20:49 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix TestLib::slurp_file() with offset on windows. 3c5b0685b921 used setFilePointer() to set the position of the filehandle, but passed the wrong filehandle, always leaving the position at 0. Instead of just fixing that, remove use of setFilePointer(), we have a perl fd at this point, so we can just use perl's seek(). Additionally, the perl filehandle wasn't closed, just the windows filehandle. Reviewed-By: Andrew Dunstan <andrew@dunslane.net> Author: Andres Freund <andres@anarazel.de> Discussion: https://postgr.es/m/20211003173038.64mmhgxctfqn7wl6@alap3.anarazel.de Backpatch: 9.6-, like 3c5b0685b921 Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/d5fa3c086eaba8de4af289e6f0059afa05f8e1f5 Modified Files -------------- src/test/perl/TestLib.pm | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix TestLib::slurp_file() with offset on windows. @ 2021-10-04 20:49 Andres Freund <andres@anarazel.de> 0 siblings, 0 replies; 7+ messages in thread From: Andres Freund @ 2021-10-04 20:49 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix TestLib::slurp_file() with offset on windows. 3c5b0685b921 used setFilePointer() to set the position of the filehandle, but passed the wrong filehandle, always leaving the position at 0. Instead of just fixing that, remove use of setFilePointer(), we have a perl fd at this point, so we can just use perl's seek(). Additionally, the perl filehandle wasn't closed, just the windows filehandle. Reviewed-By: Andrew Dunstan <andrew@dunslane.net> Author: Andres Freund <andres@anarazel.de> Discussion: https://postgr.es/m/20211003173038.64mmhgxctfqn7wl6@alap3.anarazel.de Backpatch: 9.6-, like 3c5b0685b921 Branch ------ REL9_6_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/9e3be5c182d71d7575aa2e63d9604bfa715a432e Modified Files -------------- src/test/perl/TestLib.pm | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2021-10-04 20:49 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-10-04 20:49 pgsql: Fix TestLib::slurp_file() with offset on windows. Andres Freund <andres@anarazel.de> 2021-10-04 20:49 pgsql: Fix TestLib::slurp_file() with offset on windows. Andres Freund <andres@anarazel.de> 2021-10-04 20:49 pgsql: Fix TestLib::slurp_file() with offset on windows. Andres Freund <andres@anarazel.de> 2021-10-04 20:49 pgsql: Fix TestLib::slurp_file() with offset on windows. Andres Freund <andres@anarazel.de> 2021-10-04 20:49 pgsql: Fix TestLib::slurp_file() with offset on windows. Andres Freund <andres@anarazel.de> 2021-10-04 20:49 pgsql: Fix TestLib::slurp_file() with offset on windows. Andres Freund <andres@anarazel.de> 2021-10-04 20:49 pgsql: Fix TestLib::slurp_file() with offset on windows. Andres Freund <andres@anarazel.de>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox