pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix TestLib::slurp_file() with offset on windows.
Date: Mon, 04 Oct 2021 20:49:15 +0000
Message-ID: <E1mXUtf-0007N2-1t@gemulon.postgresql.org> (raw)

Fix TestLib::slurp_file() with offset on windows.

3c5b0685b921 used setFilePointer() to set the position of the filehandle, but
passed the wrong filehandle, always leaving the position at 0. Instead of just
fixing that, remove use of setFilePointer(), we have a perl fd at this point,
so we can just use perl's seek().

Additionally, the perl filehandle wasn't closed, just the windows filehandle.

Reviewed-By: Andrew Dunstan <andrew@dunslane.net>
Author: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/20211003173038.64mmhgxctfqn7wl6@alap3.anarazel.de
Backpatch: 9.6-, like 3c5b0685b921

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5ba397f7404e911c7822e85441d42673080c5b98

Modified Files
--------------
src/test/perl/TestLib.pm | 36 ++++++++++++++++++------------------
1 file changed, 18 insertions(+), 18 deletions(-)



view thread (7+ messages)  latest in thread

Message-ID: <E1mXUtf-0007N2-1t@gemulon.postgresql.org>
Permalink:  ../E1mXUtf-0007N2-1t@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mXUtf-0007N2-1t@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de
  Subject: Re: pgsql: Fix TestLib::slurp_file() with offset on windows.
  In-Reply-To: <E1mXUtf-0007N2-1t@gemulon.postgresql.org>
  References: <E1mXUtf-0007N2-1t@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox