pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add more $Test::Builder::Level in the TAP tests
Date: Tue, 12 Oct 2021 02:17:05 +0000
Message-ID: <E1ma7Ll-0006i8-4F@gemulon.postgresql.org> (raw)

Add more $Test::Builder::Level in the TAP tests

Incrementing the level of the call stack reported is useful for
debugging purposes as it allows to control which part of the test is
exactly failing, especially if a test is structured with subroutines
that call routines from Test::More.

This adds more incrementations of $Test::Builder::Level where debugging
gets improved (for example it does not make sense for some paths like
pg_rewind where long subroutines are used).

A note is added to src/test/perl/README about that, based on a
suggestion from Andrew Dunstan and a wording coming from both of us.

Usage of Test::Builder::Level has spread in 12, so a backpatch down to
this version is done.

Reviewed-by: Andrew Dunstan, Peter Eisentraut, Daniel Gustafsson
Discussion: https://postgr.es/m/YV1CCFwgM1RV1LeS@paquier.xyz
Backpatch-through: 12

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/bab0ff2e44b781ec1b1180c5e96bdb95c385c80b

Modified Files
--------------
src/bin/pg_archivecleanup/t/010_pg_archivecleanup.pl |  2 ++
src/bin/pg_verifybackup/t/005_bad_manifest.pl        |  6 ++++++
src/bin/psql/t/010_tab_completion.pl                 |  4 ++++
src/test/kerberos/t/001_auth.pl                      |  2 ++
src/test/perl/README                                 | 10 +++++++++-
src/test/recovery/t/001_stream_rep.pl                |  2 ++
src/test/recovery/t/003_recovery_targets.pl          |  2 ++
src/test/recovery/t/007_sync_rep.pl                  |  2 ++
src/test/recovery/t/009_twophase.pl                  |  2 ++
src/test/recovery/t/018_wal_optimize.pl              |  2 ++
10 files changed, 33 insertions(+), 1 deletion(-)



view thread (12+ messages)  latest in thread

Message-ID: <E1ma7Ll-0006i8-4F@gemulon.postgresql.org>
Permalink:  ../E1ma7Ll-0006i8-4F@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1ma7Ll-0006i8-4F@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz
  Subject: Re: pgsql: Add more $Test::Builder::Level in the TAP tests
  In-Reply-To: <E1ma7Ll-0006i8-4F@gemulon.postgresql.org>
  References: <E1ma7Ll-0006i8-4F@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox