pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Refactor basebackup.c's _tarWriteDir() function.
Date: Tue, 12 Oct 2021 17:56:03 +0000
Message-ID: <E1maM0R-0003eO-4K@gemulon.postgresql.org> (raw)

Refactor basebackup.c's _tarWriteDir() function.

Sometimes, we replace a symbolic link that we find in the data
directory with an actual directory within the tarfile that we
create. _tarWriteDir was responsible both for making this
substitution and also for writing the tar header for the
resulting directory into the tar file. Make it do only the first
of those things, and rename to convert_link_to_directory.

Substantially larger refactoring of this source file is planned,
but this little bit seemed to make sense to commit
independently.

Discussion: http://postgr.es/m/CA+Tgmobz6tuv5tr-WxURe5JA1vVcGz85k4kkvoWxcyHvDpEqFA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/967a17fe2fa77b61061c8fb1183f64a5df4e080a

Modified Files
--------------
src/backend/replication/basebackup.c | 26 ++++++++++++++------------
1 file changed, 14 insertions(+), 12 deletions(-)



Message-ID: <E1maM0R-0003eO-4K@gemulon.postgresql.org>
Permalink:  ../E1maM0R-0003eO-4K@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1maM0R-0003eO-4K@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: rhaas@postgresql.org
  Subject: Re: pgsql: Refactor basebackup.c's _tarWriteDir() function.
  In-Reply-To: <E1maM0R-0003eO-4K@gemulon.postgresql.org>
  References: <E1maM0R-0003eO-4K@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox