pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Geoghegan <pg@bowt.ie>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_amcheck: avoid unhelpful verification attempts.
Date: Wed, 13 Oct 2021 21:09:44 +0000
Message-ID: <E1malVQ-0004qt-CL@gemulon.postgresql.org> (raw)

pg_amcheck: avoid unhelpful verification attempts.

Avoid calling contrib/amcheck functions with relations that are
unsuitable for checking.  Specifically, don't attempt verification of
temporary relations, or indexes whose pg_index entry indicates that the
index is invalid, or not ready.

These relations are not supported by any of the contrib/amcheck
functions, for reasons that are pretty fundamental.  For example, the
implementation of REINDEX CONCURRENTLY can add its own "transient"
pg_index entries, which has rather unclear implications for the B-Tree
verification functions, at least in the general case -- so they just
treat it as an error.  It falls to the amcheck caller (in this case
pg_amcheck) to deal with the situation at a higher level.

pg_amcheck now simply treats these conditions as additional "visibility
concerns" when it queries system catalogs.  This is a little arbitrary.
It seems to have the least problems among any of the available
alternatives.

Author: Mark Dilger <mark.dilger@enterprisedb.com>
Reported-By: Alexander Lakhin <exclusion@gmail.com>
Reviewed-By: Peter Geoghegan <pg@bowt.ie>
Reviewed-By: Robert Haas <robertmhaas@gmail.com>
Bug: #17212
Discussion: https://postgr.es/m/17212-34dd4a1d6bba98bf@postgresql.org
Backpatch: 14-, where pg_amcheck was introduced.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d2bf06db377967b0d671ae372d513806e2a28052

Modified Files
--------------
doc/src/sgml/ref/pg_amcheck.sgml        |  12 ++
src/bin/pg_amcheck/pg_amcheck.c         |  83 ++++++++----
src/bin/pg_amcheck/t/006_bad_targets.pl | 233 ++++++++++++++++++++++++++++++++
3 files changed, 299 insertions(+), 29 deletions(-)



view thread (2+ messages)

Message-ID: <E1malVQ-0004qt-CL@gemulon.postgresql.org>
Permalink:  ../E1malVQ-0004qt-CL@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1malVQ-0004qt-CL@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: pg@bowt.ie
  Subject: Re: pgsql: pg_amcheck: avoid unhelpful verification attempts.
  In-Reply-To: <E1malVQ-0004qt-CL@gemulon.postgresql.org>
  References: <E1malVQ-0004qt-CL@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox