pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Change recently added test code for stability
Date: Wed, 13 Oct 2021 22:05:59 +0000
Message-ID: <E1mamNr-0005HQ-HS@gemulon.postgresql.org> (raw)

Change recently added test code for stability

The test code added with ff9f111bce24 fails under valgrind, and probably
other slow cases too, because if (say) autovacuum runs in between and
produces WAL of its own, the large INSERT fails to account for that in
the LSN calculations.  Rewrite to use a DO loop.

Per complaint from Andres Freund

Backpatch to all branches.

Discussion: https://postgr.es/m/20211013180338.5guyqzpkcisqugrl@alap3.anarazel.de

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5ec87619bc5d987954475444713672ca733b944a

Modified Files
--------------
src/test/recovery/t/026_overwrite_contrecord.pl | 52 ++++++++++++-------------
1 file changed, 24 insertions(+), 28 deletions(-)



view thread (7+ messages)

Message-ID: <E1mamNr-0005HQ-HS@gemulon.postgresql.org>
Permalink:  ../E1mamNr-0005HQ-HS@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mamNr-0005HQ-HS@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org
  Subject: Re: pgsql: Change recently added test code for stability
  In-Reply-To: <E1mamNr-0005HQ-HS@gemulon.postgresql.org>
  References: <E1mamNr-0005HQ-HS@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox