pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Refactor LogicalTapeSet/LogicalTape interface.
Date: Mon, 18 Oct 2021 12:15:08 +0000
Message-ID: <E1mcRXo-0000e8-Vs@gemulon.postgresql.org> (raw)

Refactor LogicalTapeSet/LogicalTape interface.

All the tape functions, like LogicalTapeRead and LogicalTapeWrite, now
take a LogicalTape as argument, instead of LogicalTapeSet+tape number.
You can create any number of LogicalTapes in a single LogicalTapeSet, and
you don't need to decide the number upfront, when you create the tape set.

This makes the tape management in hash agg spilling in nodeAgg.c simpler.

Discussion: https://www.postgresql.org/message-id/420a0ec7-602c-d406-1e75-1ef7ddc58d83%40iki.fi
Reviewed-by: Peter Geoghegan, Zhihong Yu, John Naylor

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c4649cce39a41b27db874e75ddd47adaec1b0ea4

Modified Files
--------------
src/backend/executor/nodeAgg.c     | 187 ++++-----------
src/backend/utils/sort/logtape.c   | 456 +++++++++++++++----------------------
src/backend/utils/sort/tuplesort.c | 229 +++++++++----------
src/include/nodes/execnodes.h      |   3 +-
src/include/utils/logtape.h        |  37 ++-
5 files changed, 359 insertions(+), 553 deletions(-)



Message-ID: <E1mcRXo-0000e8-Vs@gemulon.postgresql.org>
Permalink:  ../E1mcRXo-0000e8-Vs@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mcRXo-0000e8-Vs@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: heikki.linnakangas@iki.fi
  Subject: Re: pgsql: Refactor LogicalTapeSet/LogicalTape interface.
  In-Reply-To: <E1mcRXo-0000e8-Vs@gemulon.postgresql.org>
  References: <E1mcRXo-0000e8-Vs@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox