pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix parallel sort, broken by the balanced merge patch.
Date: Mon, 18 Oct 2021 17:49:09 +0000
Message-ID: <E1mcWl3-0002ZE-0k@gemulon.postgresql.org> (raw)

Fix parallel sort, broken by the balanced merge patch.

The code for initializing the tapes on each merge iteration was skipped
in a parallel worker. I put the !WORKER(state) check in wrong place while
rebasing the patch.

That caused failures in the index build in 'multiple-row-versions'
isolation test, in multiple buildfarm members. On my laptop it was easier
to reproduce by building an index on a larger table, so that you got a
parallel sort more reliably.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fc0f3b4cb0e882a9c5d51c302d4aa3591e4f80fd

Modified Files
--------------
src/backend/utils/sort/tuplesort.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)



Message-ID: <E1mcWl3-0002ZE-0k@gemulon.postgresql.org>
Permalink:  ../E1mcWl3-0002ZE-0k@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mcWl3-0002ZE-0k@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: heikki.linnakangas@iki.fi
  Subject: Re: pgsql: Fix parallel sort, broken by the balanced merge patch.
  In-Reply-To: <E1mcWl3-0002ZE-0k@gemulon.postgresql.org>
  References: <E1mcWl3-0002ZE-0k@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox