pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_dump: Reorganize getTables()
Date: Tue, 19 Oct 2021 21:22:29 +0000
Message-ID: <E1mcwZ3-00042y-2p@gemulon.postgresql.org> (raw)

pg_dump: Reorganize getTables()

Along the same lines as 047329624, ed2c7f65b and daa9fe8a5, reduce
code duplication by having just one copy of the parts of the query
that are the same across all server versions; and make the
conditionals control the smallest possible amount of code.
This also gets rid of the confusing assortment of different ways
to accomplish the same result that we had here before.

While at it, make sure all three relevant parts of the function
list the fields in the same order.  This is just neatnik-ism,
of course.

Discussion: https://postgr.es/m/1240992.1634419055@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4438eb4a495c977d8ac485dd6e544c2b6e077deb

Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 849 +++++++++++++++-------------------------------
1 file changed, 275 insertions(+), 574 deletions(-)



Message-ID: <E1mcwZ3-00042y-2p@gemulon.postgresql.org>
Permalink:  ../E1mcwZ3-00042y-2p@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mcwZ3-00042y-2p@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: pg_dump: Reorganize getTables()
  In-Reply-To: <E1mcwZ3-00042y-2p@gemulon.postgresql.org>
  References: <E1mcwZ3-00042y-2p@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox