pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Add module build directory to the PATH for TAP tests
Date: Fri, 22 Oct 2021 13:50:58 +0000
Message-ID: <E1mduwk-0000hl-N7@gemulon.postgresql.org> (raw)

Add module build directory to the PATH for TAP tests

For non-MSVC builds this is make's $(CURDIR), while for MSVC builds it
is $topdir/$Config/$module. The directory is added as the second element
in the PATH, so that the install location takes precedence, but the
added PATH element takes precedence over the rest of the PATH.

The reason for this is to allow tests to find built products that are
not installed, such as the libpq_pipeline test driver.

The libpq_pipeline test is adjusted to take advantage of this.

Based on a suggestion from Andres Freund.

Backpatch to release 14.

Discussion: https://postgr.es/m/4941f5a5-2d50-1a0e-6701-14c5fefe92d6@dunslane.net

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/52c0c11367fdac78a59997de2b24031c0501fbe7

Modified Files
--------------
src/Makefile.global.in                                  | 10 +++++-----
src/test/modules/libpq_pipeline/t/001_libpq_pipeline.pl |  7 +++----
src/tools/msvc/vcregress.pl                             |  3 +++
3 files changed, 11 insertions(+), 9 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1mduwk-0000hl-N7@gemulon.postgresql.org>
Permalink:  ../E1mduwk-0000hl-N7@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mduwk-0000hl-N7@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andrew@dunslane.net
  Subject: Re: pgsql: Add module build directory to the PATH for TAP tests
  In-Reply-To: <E1mduwk-0000hl-N7@gemulon.postgresql.org>
  References: <E1mduwk-0000hl-N7@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox