pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pg_dump: fix mis-dumping of non-global default privileges.
Date: Fri, 22 Oct 2021 19:22:49 +0000
Message-ID: <E1me07t-0002c7-35@gemulon.postgresql.org> (raw)

pg_dump: fix mis-dumping of non-global default privileges.

Non-global default privilege entries should be dumped as-is,
not made relative to the default ACL for their object type.
This would typically only matter if one had revoked some
on-by-default privileges in a global entry, and then wanted
to grant them again in a non-global entry.

Per report from Boris Korzun.  This is an old bug, so back-patch
to all supported branches.

Neil Chen, test case by Masahiko Sawada

Discussion: https://postgr.es/m/111621616618184@mail.yandex.ru
Discussion: https://postgr.es/m/CAA3qoJnr2+1dVJObNtfec=qW4Z0nz=A9+r5bZKoTSy5RDjskMw@mail.gmail.com

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/10f9faf6d87393e3599e6892576d902d4ea07143

Modified Files
--------------
src/bin/pg_dump/pg_dump.c        | 19 ++++++++++++++++++-
src/bin/pg_dump/t/002_pg_dump.pl | 40 ++++++++++++++++++++++++++++++++++++++++
2 files changed, 58 insertions(+), 1 deletion(-)



view thread (7+ messages)  latest in thread

Message-ID: <E1me07t-0002c7-35@gemulon.postgresql.org>
Permalink:  ../E1me07t-0002c7-35@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1me07t-0002c7-35@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: pg_dump: fix mis-dumping of non-global default privileges.
  In-Reply-To: <E1me07t-0002c7-35@gemulon.postgresql.org>
  References: <E1me07t-0002c7-35@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox