pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix frontend version of sh_error() in simplehash.h.
Date: Fri, 22 Oct 2021 20:43:51 +0000
Message-ID: <E1me1OJ-00031m-Vf@gemulon.postgresql.org> (raw)

Fix frontend version of sh_error() in simplehash.h.

The code does not expect sh_error() to return, but the patch
that made this header usable in frontend didn't get that memo.

While here, plaster unlikely() on the tests that decide whether
to invoke sh_error(), and add our standard copyright notice.

Noted by Andres Freund.  Back-patch to v13 where this frontend
support came in.

Discussion: https://postgr.es/m/0D54435C-1199-4361-9D74-2FBDCF8EA164@anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/974aedcea46dfd0119eea2fbb2eeacd232596f05

Modified Files
--------------
src/include/lib/simplehash.h | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)



view thread (3+ messages)  latest in thread

Message-ID: <E1me1OJ-00031m-Vf@gemulon.postgresql.org>
Permalink:  ../E1me1OJ-00031m-Vf@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1me1OJ-00031m-Vf@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix frontend version of sh_error() in simplehash.h.
  In-Reply-To: <E1me1OJ-00031m-Vf@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox