From: Noah Misch <noah@leadboat.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURR
Date: Sun, 24 Oct 2021 01:40:12 +0000
Message-ID: <E1meSUe-0004Wh-Ji@gemulon.postgresql.org> (raw)
Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURRENTLY.
CIC and REINDEX CONCURRENTLY assume backends see their catalog changes
no later than each backend's next transaction start. That failed to
hold when a backend absorbed a relevant invalidation in the middle of
running RelationBuildDesc() on the CIC index. Queries that use the
resulting index can silently fail to find rows. Fix this for future
index builds by making RelationBuildDesc() loop until it finishes
without accepting a relevant invalidation. It may be necessary to
reindex to recover from past occurrences; REINDEX CONCURRENTLY suffices.
Back-patch to 9.6 (all supported versions).
Noah Misch and Andrey Borodin, reviewed (in earlier versions) by Andres
Freund.
Discussion: https://postgr.es/m/20210730022548.GA1940096@gust.leadboat.com
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/2e33b43599ad3868ee180f149050444bf0a7ca15
Modified Files
--------------
contrib/amcheck/Makefile | 2 +
contrib/amcheck/t/002_cic.pl | 78 +++++++++++++++++++++
src/backend/utils/cache/inval.c | 12 +++-
src/backend/utils/cache/relcache.c | 115 +++++++++++++++++++++++++++++--
src/include/utils/inval.h | 1 +
src/include/utils/relcache.h | 2 +-
src/test/perl/PostgresNode.pm | 135 +++++++++++++++++++++++++++++++++++++
src/tools/pgindent/typedefs.list | 1 +
8 files changed, 336 insertions(+), 10 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: noah@leadboat.com
Subject: Re: pgsql: Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURR
In-Reply-To: <E1meSUe-0004Wh-Ji@gemulon.postgresql.org>
References: <E1meSUe-0004Wh-Ji@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox