pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: StartupXLOG: Call CleanupAfterArchiveRecovery after XLogReportPa
Date: Mon, 25 Oct 2021 14:43:27 +0000
Message-ID: <E1mf1CB-0000FL-3H@gemulon.postgresql.org> (raw)

StartupXLOG: Call CleanupAfterArchiveRecovery after XLogReportParameters.

This does a better job grouping related operations together, since
all of the WAL records that we need to write prior to allowing WAL
writes generally and written by a single uninterrupted stretch of code.

Since CleanupAfterArchiveRecovery() just (1) runs recovery_end_command,
(2) removes non-parent xlog files, and (3) archives any final partial
segment, this should be safe, because all of those things are pretty
much unrelated to the WAL record written by XLogReportParameters().

Amul Sul, per a suggestion from me

Discussion: http://postgr.es/m/CAAJ_b97fysj6sRSQEfOHj-y8Jfd5uPqOgO74qast89B4WfD+TA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a75dbf7f9ee6ff0c0e2ab4b224b04fc50c4e6577

Modified Files
--------------
src/backend/access/transam/xlog.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)



Message-ID: <E1mf1CB-0000FL-3H@gemulon.postgresql.org>
Permalink:  ../E1mf1CB-0000FL-3H@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mf1CB-0000FL-3H@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: rhaas@postgresql.org
  Subject: Re: pgsql: StartupXLOG: Call CleanupAfterArchiveRecovery after XLogReportPa
  In-Reply-To: <E1mf1CB-0000FL-3H@gemulon.postgresql.org>
  References: <E1mf1CB-0000FL-3H@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox