pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Jeff Davis <jdavis@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Allow GRANT on pg_log_backend_memory_contexts().
Date: Tue, 26 Oct 2021 20:41:11 +0000
Message-ID: <E1mfTFv-0002MJ-Qh@gemulon.postgresql.org> (raw)

Allow GRANT on pg_log_backend_memory_contexts().

Remove superuser check, allowing any user granted permissions on
pg_log_backend_memory_contexts() to log the memory contexts of any
backend.

Note that this could allow a privileged non-superuser to log the
memory contexts of a superuser backend, but as discussed, that does
not seem to be a problem.

Reviewed-by: Nathan Bossart, Bharath Rupireddy, Michael Paquier, Kyotaro Horiguchi, Andres Freund
Discussion: https://postgr.es/m/e5cf6684d17c8d1ef4904ae248605ccd6da03e72.camel@j-davis.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f0b051e322d530a340e62f2ae16d99acdbcb3d05

Modified Files
--------------
doc/src/sgml/func.sgml                       |  1 -
src/backend/catalog/system_functions.sql     |  2 ++
src/backend/utils/adt/mcxtfuncs.c            | 14 ++++--------
src/include/catalog/catversion.h             |  2 +-
src/test/regress/expected/misc_functions.out | 33 ++++++++++++++++++++++++++--
src/test/regress/sql/misc_functions.sql      | 26 ++++++++++++++++++++--
6 files changed, 62 insertions(+), 16 deletions(-)



view thread (8+ messages)  latest in thread

Message-ID: <E1mfTFv-0002MJ-Qh@gemulon.postgresql.org>
Permalink:  ../E1mfTFv-0002MJ-Qh@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mfTFv-0002MJ-Qh@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: jdavis@postgresql.org
  Subject: Re: pgsql: Allow GRANT on pg_log_backend_memory_contexts().
  In-Reply-To: <E1mfTFv-0002MJ-Qh@gemulon.postgresql.org>
  References: <E1mfTFv-0002MJ-Qh@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox