From: Peter Geoghegan <pg@bowt.ie>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Demote pg_unreachable() in heapam to an assertion.
Date: Fri, 29 Oct 2021 17:57:07 +0000
Message-ID: <E1mgW7n-0001DG-Lx@gemulon.postgresql.org> (raw)
Demote pg_unreachable() in heapam to an assertion.
Commit d168b66682, which overhauled index deletion, added a
pg_unreachable() to the end of a sort comparator used when sorting heap
TIDs from an index page. This allows the compiler to apply
optimizations that assume that the heap TIDs from the index AM must
always be unique.
That doesn't seem like a good idea now, given recent reports of
corruption involving duplicate TIDs in indexes on Postgres 14. Demote
to an assertion, just in case.
Backpatch: 14-, where index deletion was overhauled.
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/bd9f4cf0ee5336ce4f9f3103521740baccfb3825
Modified Files
--------------
src/backend/access/heap/heapam.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: pg@bowt.ie
Subject: Re: pgsql: Demote pg_unreachable() in heapam to an assertion.
In-Reply-To: <E1mgW7n-0001DG-Lx@gemulon.postgresql.org>
References: <E1mgW7n-0001DG-Lx@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox