pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Daniel Gustafsson <dgustafsson@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Replace unicode characters in comments with ascii
Date: Mon, 01 Nov 2021 21:56:02 +0000
Message-ID: <E1mhfHe-0002Ac-KQ@gemulon.postgresql.org> (raw)

Replace unicode characters in comments with ascii

The unicode characters, while in comments and not code, caused MSVC
to emit compiler warning C4819:

  The file contains a character that cannot be represented in the
  current code page (number).  Save the file in Unicode format to
  prevent data loss.

Fix by replacing the characters in print.c with descriptive comments
containing the codepoints and symbol names, and remove the character
in brin_bloom.c which was a footnote reference copied from the paper
citation.

Per report from hamerkop in the buildfarm.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/340E4118-0D0C-4E85-8141-8C40EB22DA3A@yesql.se

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/43a134f28b350c4b731db9dddf2f53c407a7077f

Modified Files
--------------
src/backend/access/brin/brin_bloom.c |   2 +-
src/fe_utils/print.c                 | 110 ++++++++++++++++++++++++++++-------
2 files changed, 91 insertions(+), 21 deletions(-)



Message-ID: <E1mhfHe-0002Ac-KQ@gemulon.postgresql.org>
Permalink:  ../E1mhfHe-0002Ac-KQ@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mhfHe-0002Ac-KQ@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: dgustafsson@postgresql.org
  Subject: Re: pgsql: Replace unicode characters in comments with ascii
  In-Reply-To: <E1mhfHe-0002Ac-KQ@gemulon.postgresql.org>
  References: <E1mhfHe-0002Ac-KQ@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox