pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Replace XLOG_INCLUDE_XID flag with a more localized flag.
Date: Tue, 02 Nov 2021 03:13:44 +0000
Message-ID: <E1mhkF6-00042g-JT@gemulon.postgresql.org> (raw)

Replace XLOG_INCLUDE_XID flag with a more localized flag.

Commit 0bead9af484c introduced XLOG_INCLUDE_XID flag to indicate that the
WAL record contains subXID-to-topXID association. It uses that flag later
to mark in CurrentTransactionState that top-xid is logged so that we
should not try to log it again with the next WAL record in the current
subtransaction. However, we can use a localized variable to pass that
information.

In passing, change the related function and variable names to make them
consistent with what the code is actually doing.

Author: Dilip Kumar
Reviewed-by: Alvaro Herrera, Amit Kapila
Discussion: https://postgr.es/m/E1mSoYz-0007Fh-D9@gemulon.postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/71db6459e6e4ef623e98f3b1e3e9fed1bfb0ae3b

Modified Files
--------------
src/backend/access/transam/xact.c       | 103 ++++++++++++++++----------------
src/backend/access/transam/xlog.c       |  13 +++-
src/backend/access/transam/xloginsert.c |  26 ++++----
src/include/access/xact.h               |   4 +-
src/include/access/xlog.h               |   4 +-
5 files changed, 82 insertions(+), 68 deletions(-)



Message-ID: <E1mhkF6-00042g-JT@gemulon.postgresql.org>
Permalink:  ../E1mhkF6-00042g-JT@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mhkF6-00042g-JT@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: akapila@postgresql.org
  Subject: Re: pgsql: Replace XLOG_INCLUDE_XID flag with a more localized flag.
  In-Reply-To: <E1mhkF6-00042g-JT@gemulon.postgresql.org>
  References: <E1mhkF6-00042g-JT@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox