pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Move MarkCurrentTransactionIdLoggedIfAny() out of the critical s
Date: Tue, 02 Nov 2021 03:50:17 +0000
Message-ID: <E1mhkoT-0004H5-Va@gemulon.postgresql.org> (raw)

Move MarkCurrentTransactionIdLoggedIfAny() out of the critical section.

We don't modify any shared state in this function which could cause
problems for any concurrent session. This will make it look similar to the
other updates for the same structure (TransactionState) which avoids
confusion for future readers of code.

Author: Dilip Kumar
Reviewed-by: Amit Kapila
Discussion: https://postgr.es/m/E1mSoYz-0007Fh-D9@gemulon.postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/335397456b7e3f9f619038cb322fbfc9dd649d4f

Modified Files
--------------
src/backend/access/transam/xlog.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)



Message-ID: <E1mhkoT-0004H5-Va@gemulon.postgresql.org>
Permalink:  ../E1mhkoT-0004H5-Va@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mhkoT-0004H5-Va@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: akapila@postgresql.org
  Subject: Re: pgsql: Move MarkCurrentTransactionIdLoggedIfAny() out of the critical s
  In-Reply-To: <E1mhkoT-0004H5-Va@gemulon.postgresql.org>
  References: <E1mhkoT-0004H5-Va@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox