pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Fujii Masao <fujii@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pgbench: Improve error-handling in pgbench.
Date: Tue, 02 Nov 2021 13:50:57 +0000
Message-ID: <E1mhuBl-0007mf-7I@gemulon.postgresql.org> (raw)

pgbench: Improve error-handling in pgbench.

Previously failures of initial connection and logfile open caused pgbench
to proceed the benchmarking, report the incomplete results and exit with
status 2. It didn't make sense to proceed the benchmarking even when
pgbench could not start as prescribed.

This commit improves pgbench so that early errors that occur when
starting benchmark such as those failures should make pgbench exit
immediately with status 1.

Author: Yugo Nagata
Reviewed-by: Fabien COELHO, Kyotaro Horiguchi, Fujii Masao
Discussion: https://postgr.es/m/TYCPR01MB5870057375ACA8A73099C649F5349@TYCPR01MB5870.jpnprd01.prod.outlook.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/cd29be5459f0e138c0f19d49ee588feeda78e3c9

Modified Files
--------------
doc/src/sgml/ref/pgbench.sgml | 10 ++++++----
src/bin/pgbench/pgbench.c     | 26 +++++++++++++++-----------
2 files changed, 21 insertions(+), 15 deletions(-)



view thread (2+ messages)

Message-ID: <E1mhuBl-0007mf-7I@gemulon.postgresql.org>
Permalink:  ../E1mhuBl-0007mf-7I@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mhuBl-0007mf-7I@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: fujii@postgresql.org
  Subject: Re: pgsql: pgbench: Improve error-handling in pgbench.
  In-Reply-To: <E1mhuBl-0007mf-7I@gemulon.postgresql.org>
  References: <E1mhuBl-0007mf-7I@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox