pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Geoghegan <pg@bowt.ie>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix parallel amvacuumcleanup safety bug.
Date: Wed, 03 Nov 2021 02:53:08 +0000
Message-ID: <E1mi6Oi-00041T-Ex@gemulon.postgresql.org> (raw)

Fix parallel amvacuumcleanup safety bug.

Commit b4af70cb inverted the return value of the function
parallel_processing_is_safe(), but missed the amvacuumcleanup test.
Index AMs that don't support parallel cleanup at all were affected.

The practical consequences of this bug were not very serious.  Hash
indexes are affected, but since they just return the number of blocks
during hashvacuumcleanup anyway, it can't have had much impact.

Author: Masahiko Sawada <sawada.mshk@gmail.com>
Discussion: https://postgr.es/m/CAD21AoA-Em+aeVPmBbL_s1V-ghsJQSxYL-i3JP8nTfPiD1wjKw@mail.gmail.com
Backpatch: 14-, where commit b4af70cb appears.

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f6162c020c880189255e77e33bde74a2b951eaae

Modified Files
--------------
src/backend/access/heap/vacuumlazy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



view thread (2+ messages)

Message-ID: <E1mi6Oi-00041T-Ex@gemulon.postgresql.org>
Permalink:  ../E1mi6Oi-00041T-Ex@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mi6Oi-00041T-Ex@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: pg@bowt.ie
  Subject: Re: pgsql: Fix parallel amvacuumcleanup safety bug.
  In-Reply-To: <E1mi6Oi-00041T-Ex@gemulon.postgresql.org>
  References: <E1mi6Oi-00041T-Ex@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox