pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: pgcrypto: Remove non-OpenSSL support
Date: Fri, 05 Nov 2021 13:09:55 +0000
Message-ID: <E1miyyh-0007VL-Ba@gemulon.postgresql.org> (raw)

pgcrypto: Remove non-OpenSSL support

pgcrypto had internal implementations of some encryption algorithms,
as an alternative to calling out to OpenSSL.  These were rarely used,
since most production installations are built with OpenSSL.  Moreover,
maintaining parallel code paths makes the code more complex and
difficult to maintain.

This patch removes these internal implementations.  Now, pgcrypto is
only built if OpenSSL support is configured.

Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Discussion: https://www.postgresql.org/message-id/flat/0b42f1df-8cba-6a30-77d7-acc241cc88c1%40enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/db7d1a7b0530e8cbd045744e1c75b0e63fb6916f

Modified Files
--------------
contrib/Makefile                    |    5 +-
contrib/pgcrypto/Makefile           |   73 +-
contrib/pgcrypto/blf.c              |  499 -----
contrib/pgcrypto/blf.h              |   46 -
contrib/pgcrypto/imath.c            | 3588 -----------------------------------
contrib/pgcrypto/imath.h            |  445 -----
contrib/pgcrypto/internal-sha2.c    |  206 --
contrib/pgcrypto/internal.c         |  585 ------
contrib/pgcrypto/pgp-mpi-internal.c |  304 ---
contrib/pgcrypto/rijndael.c         |  677 -------
contrib/pgcrypto/rijndael.h         |   59 -
contrib/pgcrypto/rijndael.tbl       | 1138 -----------
doc/src/sgml/pgcrypto.sgml          |  113 +-
src/tools/msvc/Mkvcbuild.pm         |   39 +-
src/tools/msvc/vcregress.pl         |    7 +-
15 files changed, 42 insertions(+), 7742 deletions(-)



view thread (8+ messages)  latest in thread

Message-ID: <E1miyyh-0007VL-Ba@gemulon.postgresql.org>
Permalink:  ../E1miyyh-0007VL-Ba@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1miyyh-0007VL-Ba@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org
  Subject: Re: pgsql: pgcrypto: Remove non-OpenSSL support
  In-Reply-To: <E1miyyh-0007VL-Ba@gemulon.postgresql.org>
  References: <E1miyyh-0007VL-Ba@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox