pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix gist_bool_ops to use gbtreekey2
Date: Mon, 08 Nov 2021 00:35:55 +0000
Message-ID: <E1mjsdf-0003HV-GY@gemulon.postgresql.org> (raw)

Fix gist_bool_ops to use gbtreekey2

Commit 57e3c5160b added a new GiST bool opclass, but it used gbtreekey4
to store the data, which left two bytes undefined, as reported by skink,
our valgrind animal. There was a bit more confusion, because the opclass
also used gbtreekey8 in the definition.

Fix by defining a new gbtreekey2 struct, and using it in all the places.

Discussion: https://postgr.es/m/CAE2gYzyDKJBZngssR84VGZEN=Ux=V9FV23QfPgo+7-yYnKKg4g@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e2fbb883720aa222f61eb9f3affad1c63bac7cbb

Modified Files
--------------
contrib/btree_gist/btree_bool.c             |  2 +-
contrib/btree_gist/btree_gist--1.6--1.7.sql | 23 +++++++++++++++++++----
2 files changed, 20 insertions(+), 5 deletions(-)



Message-ID: <E1mjsdf-0003HV-GY@gemulon.postgresql.org>
Permalink:  ../E1mjsdf-0003HV-GY@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mjsdf-0003HV-GY@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tomas.vondra@postgresql.org
  Subject: Re: pgsql: Fix gist_bool_ops to use gbtreekey2
  In-Reply-To: <E1mjsdf-0003HV-GY@gemulon.postgresql.org>
  References: <E1mjsdf-0003HV-GY@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox