pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix incorrect hash equality operator bug in Memoize
Date: Mon, 08 Nov 2021 01:41:01 +0000
Message-ID: <E1mjtef-0003jI-Nx@gemulon.postgresql.org> (raw)

Fix incorrect hash equality operator bug in Memoize

In v14, because we don't have a field in RestrictInfo to cache both the
left and right type's hash equality operator, we just restrict the scope
of Memoize to only when the left and right types of a RestrictInfo are the
same.

In master we add another field to RestrictInfo and cache both hash
equality operators.

Reported-by: Jaime Casanova
Author: David Rowley
Discussion: https://postgr.es/m/20210929185544.GB24346%40ahch-to
Backpatch-through: 14

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/39a3105678a247bbfdc132cd95db5b515b8cd7f6

Modified Files
--------------
src/backend/nodes/copyfuncs.c             |  3 ++-
src/backend/nodes/outfuncs.c              |  3 ++-
src/backend/optimizer/path/joinpath.c     | 31 +++++++++++++++++++++++--------
src/backend/optimizer/plan/initsplan.c    | 28 ++++++++++++++++++++--------
src/backend/optimizer/util/restrictinfo.c |  6 ++++--
src/include/nodes/pathnodes.h             |  5 +++--
6 files changed, 54 insertions(+), 22 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1mjtef-0003jI-Nx@gemulon.postgresql.org>
Permalink:  ../E1mjtef-0003jI-Nx@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mjtef-0003jI-Nx@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: drowley@postgresql.org
  Subject: Re: pgsql: Fix incorrect hash equality operator bug in Memoize
  In-Reply-To: <E1mjtef-0003jI-Nx@gemulon.postgresql.org>
  References: <E1mjtef-0003jI-Nx@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox