pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix incorrect hash equality operator bug in Memoize 2+ messages / 1 participants [nested] [flat]
* pgsql: Fix incorrect hash equality operator bug in Memoize @ 2021-11-08 01:41 David Rowley <drowley@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: David Rowley @ 2021-11-08 01:41 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix incorrect hash equality operator bug in Memoize In v14, because we don't have a field in RestrictInfo to cache both the left and right type's hash equality operator, we just restrict the scope of Memoize to only when the left and right types of a RestrictInfo are the same. In master we add another field to RestrictInfo and cache both hash equality operators. Reported-by: Jaime Casanova Author: David Rowley Discussion: https://postgr.es/m/20210929185544.GB24346%40ahch-to Backpatch-through: 14 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/39a3105678a247bbfdc132cd95db5b515b8cd7f6 Modified Files -------------- src/backend/nodes/copyfuncs.c | 3 ++- src/backend/nodes/outfuncs.c | 3 ++- src/backend/optimizer/path/joinpath.c | 31 +++++++++++++++++++++++-------- src/backend/optimizer/plan/initsplan.c | 28 ++++++++++++++++++++-------- src/backend/optimizer/util/restrictinfo.c | 6 ++++-- src/include/nodes/pathnodes.h | 5 +++-- 6 files changed, 54 insertions(+), 22 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix incorrect hash equality operator bug in Memoize @ 2021-11-08 01:41 David Rowley <drowley@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: David Rowley @ 2021-11-08 01:41 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix incorrect hash equality operator bug in Memoize In v14, because we don't have a field in RestrictInfo to cache both the left and right type's hash equality operator, we just restrict the scope of Memoize to only when the left and right types of a RestrictInfo are the same. In master we add another field to RestrictInfo and cache both hash equality operators. Reported-by: Jaime Casanova Author: David Rowley Discussion: https://postgr.es/m/20210929185544.GB24346%40ahch-to Backpatch-through: 14 Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/1f194ed6c26e67ce92437729fc46193cc6e913d2 Modified Files -------------- src/backend/optimizer/plan/initsplan.c | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2021-11-08 01:41 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-11-08 01:41 pgsql: Fix incorrect hash equality operator bug in Memoize David Rowley <drowley@postgresql.org> 2021-11-08 01:41 pgsql: Fix incorrect hash equality operator bug in Memoize David Rowley <drowley@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox