pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Reject extraneous data after SSL or GSS encryption handshake.
Date: Mon, 08 Nov 2021 16:15:32 +0000
Message-ID: <E1mk7Iy-0000Gi-MB@gemulon.postgresql.org> (raw)

Reject extraneous data after SSL or GSS encryption handshake.

The server collects up to a bufferload of data whenever it reads data
from the client socket.  When SSL or GSS encryption is requested
during startup, any additional data received with the initial
request message remained in the buffer, and would be treated as
already-decrypted data once the encryption handshake completed.
Thus, a man-in-the-middle with the ability to inject data into the
TCP connection could stuff some cleartext data into the start of
a supposedly encryption-protected database session.

This could be abused to send faked SQL commands to the server,
although that would only work if the server did not demand any
authentication data.  (However, a server relying on SSL certificate
authentication might well not do so.)

To fix, throw a protocol-violation error if the internal buffer
is not empty after the encryption handshake.

Our thanks to Jacob Champion for reporting this problem.

Security: CVE-2021-23214

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/046c2c846b741a12e7fd61d8d86bf324a20e3dfc

Modified Files
--------------
src/backend/libpq/pqcomm.c          | 12 ++++++++++++
src/backend/postmaster/postmaster.c | 13 +++++++++++++
src/include/libpq/libpq.h           |  1 +
3 files changed, 26 insertions(+)



view thread (7+ messages)  latest in thread

Message-ID: <E1mk7Iy-0000Gi-MB@gemulon.postgresql.org>
Permalink:  ../E1mk7Iy-0000Gi-MB@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mk7Iy-0000Gi-MB@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Reject extraneous data after SSL or GSS encryption handshake.
  In-Reply-To: <E1mk7Iy-0000Gi-MB@gemulon.postgresql.org>
  References: <E1mk7Iy-0000Gi-MB@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox