pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Amit Kapila <akapila@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Rename some enums to use TABLE instead of REL.
Date: Tue, 09 Nov 2021 03:17:51 +0000
Message-ID: <E1mkHdv-00049q-Hx@gemulon.postgresql.org> (raw)

Rename some enums to use TABLE instead of REL.

Commit 5a2832465f introduced some enums to represent all tables in schema
publications and used REL in their names. Use TABLE instead of REL in
those enums to avoid confusion with other objects like SEQUENCES that can
be part of a publication in the future.

In the passing, (a) Change one of the newly introduced error messages to
make it consistent for Create and Alter commands, (b) add missing alias in
one of the SQL Statements that is used to print publications associated
with the table.

Reported-by: Tomas Vondra, Peter Smith
Author: Vignesh C
Reviewed-by: Hou Zhijie, Peter Smith
Discussion: https://www.postgresql.org/message-id/CALDaNm0OANxuJ6RXqwZsM1MSY4s19nuH3734j4a72etDwvBETQ%40mail.gma...

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b3812d0b9bcf00e8478186fc287940e17912248a

Modified Files
--------------
src/backend/commands/publicationcmds.c    |  8 ++++----
src/backend/parser/gram.y                 | 14 +++++++-------
src/bin/pg_dump/pg_dump.c                 |  6 +++---
src/bin/pg_dump/pg_dump.h                 |  2 +-
src/bin/pg_dump/pg_dump_sort.c            |  6 +++---
src/bin/psql/describe.c                   |  2 +-
src/include/nodes/parsenodes.h            |  5 +++--
src/test/regress/expected/publication.out |  4 ++--
8 files changed, 24 insertions(+), 23 deletions(-)



Message-ID: <E1mkHdv-00049q-Hx@gemulon.postgresql.org>
Permalink:  ../E1mkHdv-00049q-Hx@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mkHdv-00049q-Hx@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: akapila@postgresql.org
  Subject: Re: pgsql: Rename some enums to use TABLE instead of REL.
  In-Reply-To: <E1mkHdv-00049q-Hx@gemulon.postgresql.org>
  References: <E1mkHdv-00049q-Hx@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox