From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve error messages for some callers of XLogReadRecord()
Date: Wed, 10 Nov 2021 03:12:26 +0000
Message-ID: <E1mke2E-0003ve-MO@gemulon.postgresql.org> (raw)
Improve error messages for some callers of XLogReadRecord()
A couple of code paths related to logical decoding (WAL sender, slot
advancing, etc.) use XLogReadRecord(), feeding on error messages
generated by walreader.c on a failure. All those messages have no
context, making it harder to spot from where an error could come even if
these should not happen. All the other callers of XLogReadRecord() do
that already.
Reviewed-by: Kyotaro Horiguchi
Discussion: https://postgr.es/m/YYnTH6OyOwQcAdkw@paquier.xyz
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/c9c401a5e13accc4a3a775e3feeabdc5940c9178
Modified Files
--------------
src/backend/replication/logical/logical.c | 4 ++--
src/backend/replication/logical/logicalfuncs.c | 2 +-
src/backend/replication/slotfuncs.c | 3 ++-
src/backend/replication/walsender.c | 3 ++-
4 files changed, 7 insertions(+), 5 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz
Subject: Re: pgsql: Improve error messages for some callers of XLogReadRecord()
In-Reply-To: <E1mke2E-0003ve-MO@gemulon.postgresql.org>
References: <E1mke2E-0003ve-MO@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox