pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Doc: improve protocol spec for logical replication Type messages
6+ messages / 1 participants
[nested] [flat]

* pgsql: Doc: improve protocol spec for logical replication Type messages
@ 2021-11-10 18:13  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2021-11-10 18:13 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Doc: improve protocol spec for logical replication Type messages.

protocol.sgml documented the layout for Type messages, but completely
dropped the ball otherwise, failing to explain what they are, when
they are sent, or what they're good for.  While at it, do a little
copy-editing on the description of Relation messages.

In passing, adjust the comment for apply_handle_type() to make it
clearer that we choose not to do anything when receiving a Type
message, not that we think it has no use whatsoever.

Per question from Stefen Hillman.

Discussion: https://postgr.es/m/CAPgW8pMknK5pup6=T4a_UG=Cz80Rgp=KONqJmTdHfaZb0RvnFg@mail.gmail.com

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/886801df4a23d0ee5e2b2119470cbf300242f644

Modified Files
--------------
doc/src/sgml/protocol.sgml               | 26 +++++++++++++++++++-------
src/backend/replication/logical/worker.c |  5 ++++-
2 files changed, 23 insertions(+), 8 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Doc: improve protocol spec for logical replication Type messages
@ 2021-11-10 18:13  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2021-11-10 18:13 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Doc: improve protocol spec for logical replication Type messages.

protocol.sgml documented the layout for Type messages, but completely
dropped the ball otherwise, failing to explain what they are, when
they are sent, or what they're good for.  While at it, do a little
copy-editing on the description of Relation messages.

In passing, adjust the comment for apply_handle_type() to make it
clearer that we choose not to do anything when receiving a Type
message, not that we think it has no use whatsoever.

Per question from Stefen Hillman.

Discussion: https://postgr.es/m/CAPgW8pMknK5pup6=T4a_UG=Cz80Rgp=KONqJmTdHfaZb0RvnFg@mail.gmail.com

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f4ab856e5d5080da076125bcbb09679fc46510f2

Modified Files
--------------
doc/src/sgml/protocol.sgml               | 26 +++++++++++++++++++-------
src/backend/replication/logical/worker.c |  5 ++++-
2 files changed, 23 insertions(+), 8 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Doc: improve protocol spec for logical replication Type messages
@ 2021-11-10 18:13  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2021-11-10 18:13 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Doc: improve protocol spec for logical replication Type messages.

protocol.sgml documented the layout for Type messages, but completely
dropped the ball otherwise, failing to explain what they are, when
they are sent, or what they're good for.  While at it, do a little
copy-editing on the description of Relation messages.

In passing, adjust the comment for apply_handle_type() to make it
clearer that we choose not to do anything when receiving a Type
message, not that we think it has no use whatsoever.

Per question from Stefen Hillman.

Discussion: https://postgr.es/m/CAPgW8pMknK5pup6=T4a_UG=Cz80Rgp=KONqJmTdHfaZb0RvnFg@mail.gmail.com

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/fcfb40dcc13189ed1d6791a11eb553d2329f4f6e

Modified Files
--------------
doc/src/sgml/protocol.sgml               | 26 +++++++++++++++++++-------
src/backend/replication/logical/worker.c |  5 ++++-
2 files changed, 23 insertions(+), 8 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Doc: improve protocol spec for logical replication Type messages
@ 2021-11-10 18:13  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2021-11-10 18:13 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Doc: improve protocol spec for logical replication Type messages.

protocol.sgml documented the layout for Type messages, but completely
dropped the ball otherwise, failing to explain what they are, when
they are sent, or what they're good for.  While at it, do a little
copy-editing on the description of Relation messages.

In passing, adjust the comment for apply_handle_type() to make it
clearer that we choose not to do anything when receiving a Type
message, not that we think it has no use whatsoever.

Per question from Stefen Hillman.

Discussion: https://postgr.es/m/CAPgW8pMknK5pup6=T4a_UG=Cz80Rgp=KONqJmTdHfaZb0RvnFg@mail.gmail.com

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/74da4c71d6b1fc20c546ab042135f444dd21e734

Modified Files
--------------
doc/src/sgml/protocol.sgml               | 26 +++++++++++++++++++-------
src/backend/replication/logical/worker.c |  5 ++++-
2 files changed, 23 insertions(+), 8 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Doc: improve protocol spec for logical replication Type messages
@ 2021-11-10 18:13  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2021-11-10 18:13 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Doc: improve protocol spec for logical replication Type messages.

protocol.sgml documented the layout for Type messages, but completely
dropped the ball otherwise, failing to explain what they are, when
they are sent, or what they're good for.  While at it, do a little
copy-editing on the description of Relation messages.

In passing, adjust the comment for apply_handle_type() to make it
clearer that we choose not to do anything when receiving a Type
message, not that we think it has no use whatsoever.

Per question from Stefen Hillman.

Discussion: https://postgr.es/m/CAPgW8pMknK5pup6=T4a_UG=Cz80Rgp=KONqJmTdHfaZb0RvnFg@mail.gmail.com

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/78f058411b02a54e4fde43744e35089d0ab57683

Modified Files
--------------
doc/src/sgml/protocol.sgml               | 26 +++++++++++++++++++-------
src/backend/replication/logical/worker.c |  5 ++++-
2 files changed, 23 insertions(+), 8 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* pgsql: Doc: improve protocol spec for logical replication Type messages
@ 2021-11-10 18:13  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 6+ messages in thread

From: Tom Lane @ 2021-11-10 18:13 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Doc: improve protocol spec for logical replication Type messages.

protocol.sgml documented the layout for Type messages, but completely
dropped the ball otherwise, failing to explain what they are, when
they are sent, or what they're good for.  While at it, do a little
copy-editing on the description of Relation messages.

In passing, adjust the comment for apply_handle_type() to make it
clearer that we choose not to do anything when receiving a Type
message, not that we think it has no use whatsoever.

Per question from Stefen Hillman.

Discussion: https://postgr.es/m/CAPgW8pMknK5pup6=T4a_UG=Cz80Rgp=KONqJmTdHfaZb0RvnFg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c3b33698cf88550b017620f73b94b53029897f39

Modified Files
--------------
doc/src/sgml/protocol.sgml               | 26 +++++++++++++++++++-------
src/backend/replication/logical/worker.c |  5 ++++-
2 files changed, 23 insertions(+), 8 deletions(-)



^ permalink  raw  reply  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2021-11-10 18:13 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-11-10 18:13 pgsql: Doc: improve protocol spec for logical replication Type messages Tom Lane <tgl@sss.pgh.pa.us>
2021-11-10 18:13 pgsql: Doc: improve protocol spec for logical replication Type messages Tom Lane <tgl@sss.pgh.pa.us>
2021-11-10 18:13 pgsql: Doc: improve protocol spec for logical replication Type messages Tom Lane <tgl@sss.pgh.pa.us>
2021-11-10 18:13 pgsql: Doc: improve protocol spec for logical replication Type messages Tom Lane <tgl@sss.pgh.pa.us>
2021-11-10 18:13 pgsql: Doc: improve protocol spec for logical replication Type messages Tom Lane <tgl@sss.pgh.pa.us>
2021-11-10 18:13 pgsql: Doc: improve protocol spec for logical replication Type messages Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox