pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Doc: improve protocol spec for logical replication Type messages
Date: Wed, 10 Nov 2021 18:13:28 +0000
Message-ID: <E1mks6C-0000dL-5N@gemulon.postgresql.org> (raw)

Doc: improve protocol spec for logical replication Type messages.

protocol.sgml documented the layout for Type messages, but completely
dropped the ball otherwise, failing to explain what they are, when
they are sent, or what they're good for.  While at it, do a little
copy-editing on the description of Relation messages.

In passing, adjust the comment for apply_handle_type() to make it
clearer that we choose not to do anything when receiving a Type
message, not that we think it has no use whatsoever.

Per question from Stefen Hillman.

Discussion: https://postgr.es/m/CAPgW8pMknK5pup6=T4a_UG=Cz80Rgp=KONqJmTdHfaZb0RvnFg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c3b33698cf88550b017620f73b94b53029897f39

Modified Files
--------------
doc/src/sgml/protocol.sgml               | 26 +++++++++++++++++++-------
src/backend/replication/logical/worker.c |  5 ++++-
2 files changed, 23 insertions(+), 8 deletions(-)



view thread (6+ messages)

Message-ID: <E1mks6C-0000dL-5N@gemulon.postgresql.org>
Permalink:  ../E1mks6C-0000dL-5N@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mks6C-0000dL-5N@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Doc: improve protocol spec for logical replication Type messages
  In-Reply-To: <E1mks6C-0000dL-5N@gemulon.postgresql.org>
  References: <E1mks6C-0000dL-5N@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox