pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Daniel Gustafsson <dgustafsson@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Improve publication error messages
Date: Wed, 17 Nov 2021 13:41:58 +0000
Message-ID: <E1mnLCI-0006jq-Cl@gemulon.postgresql.org> (raw)

Improve publication error messages

Commit 81d5995b4b introduced more fine-grained errormessages for
incorrect relkinds for publication, while unlogged and temporary
tables were reported with using the same message.  This provides
separate error messages for these types of relpersistence.

Author: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Reviewed-by: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Reviewed-by: Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>
Reviewed-by: Euler Taveira <euler@eulerto.com>
Discussion: https://postgr.es/m/CALj2ACW9S=AswyQHjtO6WMcsergMkCBTtzXGrM8DX26DzfeTLQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/aa12781b0d039d93e1a851ece4bc75c3746cbd43

Modified Files
--------------
contrib/postgres_fdw/expected/postgres_fdw.out |  6 ++++++
contrib/postgres_fdw/sql/postgres_fdw.sql      |  5 +++++
src/backend/catalog/pg_publication.c           | 10 ++++++++--
src/test/regress/expected/publication.out      | 16 ++++++++++++++++
src/test/regress/sql/publication.sql           | 14 ++++++++++++++
5 files changed, 49 insertions(+), 2 deletions(-)



Message-ID: <E1mnLCI-0006jq-Cl@gemulon.postgresql.org>
Permalink:  ../E1mnLCI-0006jq-Cl@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mnLCI-0006jq-Cl@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: dgustafsson@postgresql.org
  Subject: Re: pgsql: Improve publication error messages
  In-Reply-To: <E1mnLCI-0006jq-Cl@gemulon.postgresql.org>
  References: <E1mnLCI-0006jq-Cl@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox