pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Handle close() failures more robustly in pg_dump and pg_baseback
Date: Wed, 17 Nov 2021 18:08:41 +0000
Message-ID: <E1mnPMP-0008Eu-DX@gemulon.postgresql.org> (raw)

Handle close() failures more robustly in pg_dump and pg_basebackup.

Coverity complained that applying get_gz_error after a failed gzclose,
as we did in one place in pg_basebackup, is unsafe.  I think it's
right: it's entirely likely that the call is touching freed memory.
Change that to inspect errno, as we do for other gzclose calls.

Also, be careful to initialize errno to zero immediately before any
gzclose() call where we care about the error status.  (There are
some calls where we don't, because we already failed at some previous
step.)  This ensures that we don't get a misleadingly irrelevant
error code if gzclose() fails in a way that doesn't set errno.
We could work harder at that, but it looks to me like all such cases
are basically can't-happen if we're not misusing zlib, so it's
not worth the extra notational cruft that would be required.

Also, fix several places that simply failed to check for close-time
errors at all, mostly at some remove from the close or gzclose itself;
and one place that did check but didn't bother to report the errno.

Back-patch to v12.  These mistakes are older than that, but between
the frontend logging API changes that happened in v12 and the fact
that frontend code can't rely on %m before that, the patch would need
substantial revision to work in older branches.  It doesn't quite
seem worth the trouble given the lack of related field complaints.

Patch by me; thanks to Michael Paquier for review.

Discussion: https://postgr.es/m/1343113.1636489231@sss.pgh.pa.us

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/12bf118899eb95a9b3afd67ab666698a1019e1e8

Modified Files
--------------
src/bin/pg_basebackup/pg_basebackup.c | 5 +++--
src/bin/pg_basebackup/receivelog.c    | 7 ++++++-
src/bin/pg_basebackup/walmethods.c    | 3 +++
src/bin/pg_dump/pg_backup_archiver.c  | 2 ++
src/bin/pg_dump/pg_backup_directory.c | 9 ++++++---
src/bin/pg_dump/pg_backup_tar.c       | 5 ++++-
6 files changed, 24 insertions(+), 7 deletions(-)



view thread (4+ messages)

Message-ID: <E1mnPMP-0008Eu-DX@gemulon.postgresql.org>
Permalink:  ../E1mnPMP-0008Eu-DX@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mnPMP-0008Eu-DX@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Handle close() failures more robustly in pg_dump and pg_baseback
  In-Reply-To: <E1mnPMP-0008Eu-DX@gemulon.postgresql.org>
  References: <E1mnPMP-0008Eu-DX@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox