pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Use appropriate -Wno-warning switches when compiling bitcode.
Date: Thu, 18 Nov 2021 19:50:49 +0000
Message-ID: <E1mnnQn-0000Xi-0U@gemulon.postgresql.org> (raw)

Use appropriate -Wno-warning switches when compiling bitcode.

We use "clang" to compile bitcode files for LLVM inlining.  That might
be different from the build's main C compiler, so it needs its own set
of compiler flags.  To simplify configure, we don't bother adding any
-W switches to that flag set; there's little need since the main build
will show us any warnings.  However, if we don't want to see unwanted
warnings, we still have to add any -Wno-warning switches we'd normally
use with clang.

This escaped notice before commit 9ff47ea41, which tried to add
-Wno-compound-token-split-by-macro; buildfarm animals using mismatched
CC and CLANG still showed those warnings.  I'm not sure why we never
saw any effects from the lack of -Wno-unused-command-line-argument
(maybe that's only activated by -Wall?).  clang does not currently
support -Wno-format-truncation or -Wno-stringop-truncation, although
in the interests of future-proofing and consistency I included tests
for those.

Back-patch to v11 where we started building bitcode files.

Discussion: https://postgr.es/m/2921539.1637254619@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/276517a96484f9e39a7a1095ab39fa76ef1ee8cc

Modified Files
--------------
configure    | 194 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++---
configure.ac |  46 +++++++++++---
2 files changed, 222 insertions(+), 18 deletions(-)



view thread (5+ messages)

Message-ID: <E1mnnQn-0000Xi-0U@gemulon.postgresql.org>
Permalink:  ../E1mnnQn-0000Xi-0U@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mnnQn-0000Xi-0U@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Use appropriate -Wno-warning switches when compiling bitcode.
  In-Reply-To: <E1mnnQn-0000Xi-0U@gemulon.postgresql.org>
  References: <E1mnnQn-0000Xi-0U@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox