pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Be more specific about OOM in XLogReaderAllocate
Date: Mon, 22 Nov 2021 16:45:21 +0000
Message-ID: <E1mpCRV-0007vv-P0@gemulon.postgresql.org> (raw)

Be more specific about OOM in XLogReaderAllocate

A couple of spots can benefit from an added errdetail(), which matches
what we were already doing in other places; and those that cannot
withstand errdetail() can get a more descriptive primary message.

Author: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Reviewed-by: Julien Rouhaud <rjuju123@gmail.com>
Discussion: https://postgr.es/m/CALj2ACV+cX1eM03GfcA=ZMLXh5fSn1X1auJLz3yuS1duPSb9QA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2fed48f48f7f2f7a6d6f6d020f046efe3c249828

Modified Files
--------------
src/backend/access/transam/xlog.c         | 2 +-
src/backend/replication/logical/logical.c | 3 ++-
src/backend/replication/walsender.c       | 3 ++-
src/bin/pg_rewind/parsexlog.c             | 6 +++---
src/bin/pg_waldump/pg_waldump.c           | 2 +-
5 files changed, 9 insertions(+), 7 deletions(-)



Message-ID: <E1mpCRV-0007vv-P0@gemulon.postgresql.org>
Permalink:  ../E1mpCRV-0007vv-P0@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mpCRV-0007vv-P0@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org
  Subject: Re: pgsql: Be more specific about OOM in XLogReaderAllocate
  In-Reply-To: <E1mpCRV-0007vv-P0@gemulon.postgresql.org>
  References: <E1mpCRV-0007vv-P0@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox