pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Probe $PROVE not $PERL while checking for modules needed by TAP 6+ messages / 1 participants [nested] [flat]
* pgsql: Probe $PROVE not $PERL while checking for modules needed by TAP @ 2021-11-22 17:55 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2021-11-22 17:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Probe $PROVE not $PERL while checking for modules needed by TAP tests. Normally "prove" and "perl" come from the same Perl installation, but we support the case where they don't (mainly because the MSys buildfarm animals need this). In that case, AX_PROG_PERL_MODULES is completely the wrong thing to use, because it's checking what "perl" has. Instead, make a little TAP test script including the required modules, and run that under "prove". We don't need ax_prog_perl_modules.m4 at all after this change, so remove it. Back-patch to all supported branches, for the buildfarm's benefit. (In v10, this also back-patches the effects of commit 264eb03aa.) Andrew Dunstan and Tom Lane, per an observation by Noah Misch Discussion: https://postgr.es/m/E1moZHS-0002Cu-Ei@gemulon.postgresql.org Branch ------ REL_12_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/0416c9c18b35c85dd55eb35cd08a4b66564301c1 Modified Files -------------- aclocal.m4 | 1 - config/ax_prog_perl_modules.m4 | 77 ----------------------------- config/check_modules.pl | 20 ++++++++ configure | 108 +++++++---------------------------------- configure.in | 26 +++++----- 5 files changed, 53 insertions(+), 179 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Probe $PROVE not $PERL while checking for modules needed by TAP @ 2021-11-22 17:55 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2021-11-22 17:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Probe $PROVE not $PERL while checking for modules needed by TAP tests. Normally "prove" and "perl" come from the same Perl installation, but we support the case where they don't (mainly because the MSys buildfarm animals need this). In that case, AX_PROG_PERL_MODULES is completely the wrong thing to use, because it's checking what "perl" has. Instead, make a little TAP test script including the required modules, and run that under "prove". We don't need ax_prog_perl_modules.m4 at all after this change, so remove it. Back-patch to all supported branches, for the buildfarm's benefit. (In v10, this also back-patches the effects of commit 264eb03aa.) Andrew Dunstan and Tom Lane, per an observation by Noah Misch Discussion: https://postgr.es/m/E1moZHS-0002Cu-Ei@gemulon.postgresql.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/c4fe3199a6d65212537a59eb0d7e6fad22b9e903 Modified Files -------------- aclocal.m4 | 1 - config/ax_prog_perl_modules.m4 | 77 ----------------------------- config/check_modules.pl | 20 ++++++++ configure | 110 +++++++---------------------------------- configure.ac | 28 ++++++----- 5 files changed, 53 insertions(+), 183 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Probe $PROVE not $PERL while checking for modules needed by TAP @ 2021-11-22 17:55 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2021-11-22 17:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Probe $PROVE not $PERL while checking for modules needed by TAP tests. Normally "prove" and "perl" come from the same Perl installation, but we support the case where they don't (mainly because the MSys buildfarm animals need this). In that case, AX_PROG_PERL_MODULES is completely the wrong thing to use, because it's checking what "perl" has. Instead, make a little TAP test script including the required modules, and run that under "prove". We don't need ax_prog_perl_modules.m4 at all after this change, so remove it. Back-patch to all supported branches, for the buildfarm's benefit. (In v10, this also back-patches the effects of commit 264eb03aa.) Andrew Dunstan and Tom Lane, per an observation by Noah Misch Discussion: https://postgr.es/m/E1moZHS-0002Cu-Ei@gemulon.postgresql.org Branch ------ REL_10_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/c23796b1a65fef18a52c8583c94e864e0a5692ea Modified Files -------------- aclocal.m4 | 1 - config/ax_prog_perl_modules.m4 | 77 ------------------------------- config/check_modules.pl | 20 ++++++++ configure | 102 ++++++++--------------------------------- configure.in | 24 ++++++---- 5 files changed, 53 insertions(+), 171 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Probe $PROVE not $PERL while checking for modules needed by TAP @ 2021-11-22 17:55 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2021-11-22 17:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Probe $PROVE not $PERL while checking for modules needed by TAP tests. Normally "prove" and "perl" come from the same Perl installation, but we support the case where they don't (mainly because the MSys buildfarm animals need this). In that case, AX_PROG_PERL_MODULES is completely the wrong thing to use, because it's checking what "perl" has. Instead, make a little TAP test script including the required modules, and run that under "prove". We don't need ax_prog_perl_modules.m4 at all after this change, so remove it. Back-patch to all supported branches, for the buildfarm's benefit. (In v10, this also back-patches the effects of commit 264eb03aa.) Andrew Dunstan and Tom Lane, per an observation by Noah Misch Discussion: https://postgr.es/m/E1moZHS-0002Cu-Ei@gemulon.postgresql.org Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ead5c367d32e08a5779617a6f8adf97082dde557 Modified Files -------------- aclocal.m4 | 1 - config/ax_prog_perl_modules.m4 | 77 ----------------------------- config/check_modules.pl | 20 ++++++++ configure | 108 +++++++---------------------------------- configure.in | 26 +++++----- 5 files changed, 53 insertions(+), 179 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Probe $PROVE not $PERL while checking for modules needed by TAP @ 2021-11-22 17:55 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2021-11-22 17:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Probe $PROVE not $PERL while checking for modules needed by TAP tests. Normally "prove" and "perl" come from the same Perl installation, but we support the case where they don't (mainly because the MSys buildfarm animals need this). In that case, AX_PROG_PERL_MODULES is completely the wrong thing to use, because it's checking what "perl" has. Instead, make a little TAP test script including the required modules, and run that under "prove". We don't need ax_prog_perl_modules.m4 at all after this change, so remove it. Back-patch to all supported branches, for the buildfarm's benefit. (In v10, this also back-patches the effects of commit 264eb03aa.) Andrew Dunstan and Tom Lane, per an observation by Noah Misch Discussion: https://postgr.es/m/E1moZHS-0002Cu-Ei@gemulon.postgresql.org Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/e9af18c6c5512566c409c2ff99083fc1d89ff314 Modified Files -------------- aclocal.m4 | 1 - config/ax_prog_perl_modules.m4 | 77 ----------------------------- config/check_modules.pl | 20 ++++++++ configure | 108 +++++++---------------------------------- configure.ac | 26 +++++----- 5 files changed, 53 insertions(+), 179 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
* pgsql: Probe $PROVE not $PERL while checking for modules needed by TAP @ 2021-11-22 17:55 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 6+ messages in thread From: Tom Lane @ 2021-11-22 17:55 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Probe $PROVE not $PERL while checking for modules needed by TAP tests. Normally "prove" and "perl" come from the same Perl installation, but we support the case where they don't (mainly because the MSys buildfarm animals need this). In that case, AX_PROG_PERL_MODULES is completely the wrong thing to use, because it's checking what "perl" has. Instead, make a little TAP test script including the required modules, and run that under "prove". We don't need ax_prog_perl_modules.m4 at all after this change, so remove it. Back-patch to all supported branches, for the buildfarm's benefit. (In v10, this also back-patches the effects of commit 264eb03aa.) Andrew Dunstan and Tom Lane, per an observation by Noah Misch Discussion: https://postgr.es/m/E1moZHS-0002Cu-Ei@gemulon.postgresql.org Branch ------ REL_13_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ec383ca2df0a6f77a9b49dcd8853e76e6b328d37 Modified Files -------------- aclocal.m4 | 1 - config/ax_prog_perl_modules.m4 | 77 ----------------------------- config/check_modules.pl | 20 ++++++++ configure | 108 +++++++---------------------------------- configure.in | 26 +++++----- 5 files changed, 53 insertions(+), 179 deletions(-) ^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2021-11-22 17:55 UTC | newest] Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-11-22 17:55 pgsql: Probe $PROVE not $PERL while checking for modules needed by TAP Tom Lane <tgl@sss.pgh.pa.us> 2021-11-22 17:55 pgsql: Probe $PROVE not $PERL while checking for modules needed by TAP Tom Lane <tgl@sss.pgh.pa.us> 2021-11-22 17:55 pgsql: Probe $PROVE not $PERL while checking for modules needed by TAP Tom Lane <tgl@sss.pgh.pa.us> 2021-11-22 17:55 pgsql: Probe $PROVE not $PERL while checking for modules needed by TAP Tom Lane <tgl@sss.pgh.pa.us> 2021-11-22 17:55 pgsql: Probe $PROVE not $PERL while checking for modules needed by TAP Tom Lane <tgl@sss.pgh.pa.us> 2021-11-22 17:55 pgsql: Probe $PROVE not $PERL while checking for modules needed by TAP Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox