From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Probe $PROVE not $PERL while checking for modules needed by TAP
Date: Mon, 22 Nov 2021 17:55:29 +0000
Message-ID: <E1mpDXN-0008Le-3i@gemulon.postgresql.org> (raw)
Probe $PROVE not $PERL while checking for modules needed by TAP tests.
Normally "prove" and "perl" come from the same Perl installation,
but we support the case where they don't (mainly because the MSys
buildfarm animals need this). In that case, AX_PROG_PERL_MODULES
is completely the wrong thing to use, because it's checking what
"perl" has. Instead, make a little TAP test script including the
required modules, and run that under "prove".
We don't need ax_prog_perl_modules.m4 at all after this change,
so remove it.
Back-patch to all supported branches, for the buildfarm's benefit.
(In v10, this also back-patches the effects of commit 264eb03aa.)
Andrew Dunstan and Tom Lane, per an observation by Noah Misch
Discussion: https://postgr.es/m/E1moZHS-0002Cu-Ei@gemulon.postgresql.org
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/ec383ca2df0a6f77a9b49dcd8853e76e6b328d37
Modified Files
--------------
aclocal.m4 | 1 -
config/ax_prog_perl_modules.m4 | 77 -----------------------------
config/check_modules.pl | 20 ++++++++
configure | 108 +++++++----------------------------------
configure.in | 26 +++++-----
5 files changed, 53 insertions(+), 179 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us
Subject: Re: pgsql: Probe $PROVE not $PERL while checking for modules needed by TAP
In-Reply-To: <E1mpDXN-0008Le-3i@gemulon.postgresql.org>
References: <E1mpDXN-0008Le-3i@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox