pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Rowley <drowley@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Flush Memoize cache when non-key parameters change, take 2
Date: Wed, 24 Nov 2021 10:29:40 +0000
Message-ID: <E1mppX2-0005Sj-DT@gemulon.postgresql.org> (raw)

Flush Memoize cache when non-key parameters change, take 2

It's possible that a subplan below a Memoize node contains a parameter
from above the Memoize node.  If this parameter changes then cache entries
may become out-dated due to the new parameter value.

Previously Memoize was mistakenly not aware of this.  We fix this here by
flushing the cache whenever a parameter that's not part of the cache
key changes.

Bug: #17213
Reported by: Elvis Pranskevichus
Author: David Rowley
Discussion: https://postgr.es/m/17213-988ed34b225a2862@postgresql.org
Backpatch-through: 14, where Memoize was added

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/411137a429210e432f923264a8e313a9872910ca

Modified Files
--------------
src/backend/executor/nodeMemoize.c      | 38 ++++++++++++++++++++++++++++++++
src/backend/nodes/bitmapset.c           |  2 ++
src/backend/nodes/copyfuncs.c           |  1 +
src/backend/nodes/outfuncs.c            |  1 +
src/backend/nodes/readfuncs.c           |  1 +
src/backend/optimizer/plan/createplan.c | 10 ++++++---
src/backend/optimizer/util/clauses.c    | 31 ++++++++++++++++++++++++++
src/include/nodes/execnodes.h           |  2 ++
src/include/nodes/plannodes.h           |  1 +
src/include/optimizer/clauses.h         |  2 ++
src/test/regress/expected/memoize.out   | 39 +++++++++++++++++++++++++++++++++
src/test/regress/sql/memoize.sql        | 20 +++++++++++++++++
12 files changed, 145 insertions(+), 3 deletions(-)



view thread (8+ messages)  latest in thread

Message-ID: <E1mppX2-0005Sj-DT@gemulon.postgresql.org>
Permalink:  ../E1mppX2-0005Sj-DT@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mppX2-0005Sj-DT@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: drowley@postgresql.org
  Subject: Re: pgsql: Flush Memoize cache when non-key parameters change, take 2
  In-Reply-To: <E1mppX2-0005Sj-DT@gemulon.postgresql.org>
  References: <E1mppX2-0005Sj-DT@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox