From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Simplify declaring variables exported from libpgcommon and libpg
Date: Mon, 29 Nov 2021 16:00:06 +0000
Message-ID: <E1mrj4Y-0006lT-GJ@gemulon.postgresql.org> (raw)
Simplify declaring variables exported from libpgcommon and libpgport.
This reverts commits c2d1eea9e and 11b500072, as well as similar hacks
elsewhere, in favor of setting up the PGDLLIMPORT macro so that it can
just be used unconditionally. That can work because in frontend code,
we need no marking in either the defining or consuming files for a
variable exported from these libraries; and frontend code has no need
to access variables exported from the core backend, either.
While at it, write some actual documentation about the PGDLLIMPORT
and PGDLLEXPORT macros.
Patch by me, based on a suggestion from Robert Haas.
Discussion: https://postgr.es/m/1160385.1638165449@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/e04a8059a74c125a8af94acdcb7b15b92188470a
Modified Files
--------------
src/include/c.h | 14 +++++++++++++-
src/include/common/keywords.h | 6 ------
src/include/common/pg_prng.h | 4 ----
src/include/port/cygwin.h | 10 ++++++++--
src/include/port/pg_bitutils.h | 6 ------
src/include/port/win32.h | 14 ++++++++++++--
6 files changed, 33 insertions(+), 21 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us
Subject: Re: pgsql: Simplify declaring variables exported from libpgcommon and libpg
In-Reply-To: <E1mrj4Y-0006lT-GJ@gemulon.postgresql.org>
References: <E1mrj4Y-0006lT-GJ@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox