pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Fix regression test failure caused by commit 4f0b0966c8 2+ messages / 2 participants [nested] [flat]
* pgsql: Fix regression test failure caused by commit 4f0b0966c8 @ 2021-04-07 22:14 Bruce Momjian <bruce@momjian.us> 0 siblings, 0 replies; 2+ messages in thread From: Bruce Momjian @ 2021-04-07 22:14 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix regression test failure caused by commit 4f0b0966c8 The query originally used was too simple, cause explain_filter() to be unable to remove JIT output text. Reported-by: Tom Lane Author: Julien Rouhaud Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/bc70728693bc2d28db7125e7a24d78ad7612f58c Modified Files -------------- src/test/regress/expected/explain.out | 10 +++++----- src/test/regress/sql/explain.sql | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix regression test failure caused by commit 8d74fc96db. @ 2021-12-01 07:34 Amit Kapila <akapila@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Amit Kapila @ 2021-12-01 07:34 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Fix regression test failure caused by commit 8d74fc96db. The tests didn't considered that an error unrelated to apply changes, e.g. "replication origin with OID %d is already active ...", could occur on the table sync worker before starting to copy changes. To make the test robust we instead need to check the expected error and the source of error which will be either tablesync or apply worker. In passing remove the harmless option "streaming = off" from Create Subscription command as that is anyway the default. Per buildfarm member sidewinder. Author: Masahiko Sawada Reviewed-by: Hou Zhijie, Vignesh C, Amit Kapila Discussion: https://postgr.es/m/CAD21AoDeScrsHhLyEPYqN3sydg6PxAPVBboK=30xJfUVihNZDA@mail.gmail.com Discussion: https://postgr.es/m/E1mrtvV-0002Gz-73@gemulon.postgresql.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/41e66fee051619ab84828814554f73556a958850 Modified Files -------------- src/test/subscription/t/026_worker_stats.pl | 59 +++++++++++++++++------------ 1 file changed, 34 insertions(+), 25 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2021-12-01 07:34 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-04-07 22:14 pgsql: Fix regression test failure caused by commit 4f0b0966c8 Bruce Momjian <bruce@momjian.us> 2021-12-01 07:34 pgsql: Fix regression test failure caused by commit 8d74fc96db. Amit Kapila <akapila@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox